From 659240889f85719d6e73610d4804b2d3f7e8bf80 Mon Sep 17 00:00:00 2001
From: Kamil Trzcinski <ayufan@ayufan.eu>
Date: Mon, 4 Apr 2022 22:44:01 +0200
Subject: [PATCH] set device settings

---
 device.c |  2 +-
 device.h |  9 ++++++---
 main.c   | 26 +++++++++++++++++---------
 3 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/device.c b/device.c
index 193c37c..dda02c0 100644
--- a/device.c
+++ b/device.c
@@ -182,7 +182,7 @@ int device_set_option(device_t *dev, const char *name, uint32_t id, int32_t valu
   struct v4l2_control ctl = {0};
   ctl.id = id;
   ctl.value = value;
-  E_LOG_DEBUG(dev, "Configuring option %s ...", name);
+  E_LOG_DEBUG(dev, "Configuring option %s (%08x) = %d", name, id, value);
   E_XIOCTL(dev, dev->fd, VIDIOC_S_CTRL, &ctl, "Can't set option %s", name);
   return 0;
 error:
diff --git a/device.h b/device.h
index 4ede414..fbb6e01 100644
--- a/device.h
+++ b/device.h
@@ -26,8 +26,11 @@ int device_force_key(device_t *dev);
 int device_set_option(device_t *dev, const char *name, uint32_t id, int32_t value);
 int device_set_fps(device_t *dev, int desired_fps);
 
-#define DEVICE_SET_OPTION(dev, type, name, value) \
+#define DEVICE_SET_OPTION(dev, name, value) \
+  device_set_option(dev, #name, V4L2_CID_##name, value)
+
+#define DEVICE_SET_OPTION2(dev, type, name, value) \
   device_set_option(dev, #name, V4L2_CID_##type##_##name, value)
 
-#define DEVICE_SET_OPTION_FATAL(dev, type, name, value) \
-  do { if (DEVICE_SET_OPTION(dev, type, name, value) < 0) return -1; } while(0)
+#define DEVICE_SET_OPTION2_FATAL(dev, type, name, value) \
+  do { if (DEVICE_SET_OPTION2(dev, type, name, value) < 0) return -1; } while(0)
diff --git a/main.c b/main.c
index 8fdfb52..5dcce7f 100644
--- a/main.c
+++ b/main.c
@@ -22,6 +22,10 @@ device_t *codec_h264 = NULL;
 
 int open_isp(buffer_list_t *src, const char *srgb_path, const char *yuuv_path, const char *yuuv_low_path)
 {
+  DEVICE_SET_OPTION(isp_srgb, RED_BALANCE, 2120);
+  DEVICE_SET_OPTION(isp_srgb, BLUE_BALANCE, 1472);
+  DEVICE_SET_OPTION(isp_srgb, DIGITAL_GAIN, 1007);
+
   if (device_open_buffer_list(isp_srgb, false, src->fmt_width, src->fmt_height, src->fmt_format, camera_nbufs) < 0 ||
     device_open_buffer_list(isp_yuuv, true, src->fmt_width, src->fmt_height, V4L2_PIX_FMT_YUYV, camera_nbufs) < 0 ||
     device_open_buffer_list(isp_yuuv_low, true, src->fmt_width / 2, src->fmt_height / 2, V4L2_PIX_FMT_YUYV, camera_nbufs) < 0) {
@@ -33,28 +37,28 @@ int open_isp(buffer_list_t *src, const char *srgb_path, const char *yuuv_path, c
 
 int open_jpeg(buffer_list_t *src, const char *tmp)
 {
+  DEVICE_SET_OPTION2(codec_jpeg, JPEG, COMPRESSION_QUALITY, 80);
+
   if (device_open_buffer_list(codec_jpeg, false, src->fmt_width, src->fmt_height, src->fmt_format, camera_nbufs) < 0 ||
     device_open_buffer_list(codec_jpeg, true, src->fmt_width, src->fmt_height, V4L2_PIX_FMT_JPEG, camera_nbufs) < 0) {
     return -1;
   }
-
-  DEVICE_SET_OPTION(codec_jpeg, JPEG, COMPRESSION_QUALITY, 80);
   return 0;
 }
 
 int open_h264(buffer_list_t *src, const char *tmp)
 {
+  DEVICE_SET_OPTION2(codec_h264, MPEG_VIDEO, BITRATE, 5000 * 1000);
+  DEVICE_SET_OPTION2(codec_h264, MPEG_VIDEO, H264_I_PERIOD, 30);
+  DEVICE_SET_OPTION2(codec_h264, MPEG_VIDEO, H264_LEVEL, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
+  DEVICE_SET_OPTION2(codec_h264, MPEG_VIDEO, REPEAT_SEQ_HEADER, 1);
+  DEVICE_SET_OPTION2(codec_h264, MPEG_VIDEO, H264_MIN_QP, 16);
+  DEVICE_SET_OPTION2(codec_h264, MPEG_VIDEO, H264_MIN_QP, 32);
+
   if (device_open_buffer_list(codec_h264, false, src->fmt_width, src->fmt_height, src->fmt_format, camera_nbufs) < 0 ||
     device_open_buffer_list(codec_h264, true, src->fmt_width, src->fmt_height, V4L2_PIX_FMT_H264, camera_nbufs) < 0) {
     return -1;
   }
-
-  DEVICE_SET_OPTION(codec_h264, MPEG_VIDEO, BITRATE, 5000 * 1000);
-  DEVICE_SET_OPTION(codec_h264, MPEG_VIDEO, H264_I_PERIOD, 30);
-  DEVICE_SET_OPTION(codec_h264, MPEG_VIDEO, H264_LEVEL, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
-  DEVICE_SET_OPTION(codec_h264, MPEG_VIDEO, REPEAT_SEQ_HEADER, 1);
-  DEVICE_SET_OPTION(codec_h264, MPEG_VIDEO, H264_MIN_QP, 16);
-  DEVICE_SET_OPTION(codec_h264, MPEG_VIDEO, H264_MIN_QP, 32);
   return 0;
 }
 
@@ -66,6 +70,10 @@ int open_camera()
     return -1;
   }
 
+  DEVICE_SET_OPTION(camera, EXPOSURE, 1148);
+  DEVICE_SET_OPTION(camera, ANALOGUE_GAIN, 938);
+  DEVICE_SET_OPTION(camera, DIGITAL_GAIN, 256);
+
   isp_srgb = device_open("ISP-SRGB", "/dev/video13");
   //isp_srgb->allow_dma = false;
   isp_yuuv = device_open("ISP-YUUV", "/dev/video14");